chore: rust dockerfile #80
Conversation
|
👋 Thanks for assigning @tankyleo as a reviewer! |
|
🔔 1st Reminder Hey @tankyleo! This PR has been waiting for your review. |
|
🔔 2nd Reminder Hey @tankyleo! This PR has been waiting for your review. |
|
🔔 3rd Reminder Hey @tankyleo! This PR has been waiting for your review. |
tankyleo
left a comment
tankyleo
left a comment
There was a problem hiding this comment.
Thanks ! can you make this one commit / remove the merge commit in the current PR ?
rust/Dockerfile
Outdated
| ca-certificates \ | ||
| libssl3 \ |
There was a problem hiding this comment.
Wasn't aware of these dependencies are you sure these are needed ?
There was a problem hiding this comment.
Likely yes (cf. #77), though IIRC I had to also install libssl-dev and pkg-config, too (cf. https://docs.rs/openssl/latest/openssl/#automatic).
There was a problem hiding this comment.
without libssl3 I get:
error while loading shared libraries: libssl.so.3: cannot open shared object file: No such file or directory
when trying to run the image
There was a problem hiding this comment.
ca-certificate seems not needed, I'll remove it, thanks.
There was a problem hiding this comment.
@frnandu let's bring back ca-certificates sorry these are needed in case the user configures HTTPS requests to the postgres database.
tankyleo
left a comment
tankyleo
left a comment
There was a problem hiding this comment.
As mentioned above, let's bring back ca-certificates for HTTPS requests.
Also squash all the commits into a single one.
4 participants
fixes #74